fix(host): eliminate spurious error logs in standalone mode#8287
Open
codefromthecrypt wants to merge 3 commits intoenvoyproxy:mainfrom
Open
fix(host): eliminate spurious error logs in standalone mode#8287codefromthecrypt wants to merge 3 commits intoenvoyproxy:mainfrom
codefromthecrypt wants to merge 3 commits intoenvoyproxy:mainfrom
Conversation
Seed the offline fake Kubernetes client with CertGen secrets and make DeleteRateLimitInfra a no-op to fix 4 non-actionable ERROR logs emitted on every standalone mode startup. Fixes envoyproxy#6596 Signed-off-by: Adrian Cole <adrian@tetrate.io>
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #8287 +/- ##
==========================================
+ Coverage 73.63% 73.73% +0.09%
==========================================
Files 242 242
Lines 37000 37007 +7
==========================================
+ Hits 27245 27287 +42
+ Misses 7838 7796 -42
- Partials 1917 1924 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zirain
approved these changes
Feb 18, 2026
jukie
approved these changes
Feb 18, 2026
Contributor
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix(host): eliminate spurious error logs in standalone mode
What this PR does / why we need it:
Fixes the root causes of 4 non-actionable ERROR logs emitted on every standalone mode startup: seeds the offline fake Kubernetes client with CertGen secrets and makes
DeleteRateLimitInfraa no-op.Which issue(s) this PR fixes:
Fixes #6596
Release Notes: Yes